Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow configurable config home directory #42

Merged
merged 4 commits into from
Oct 17, 2023
Merged

feat: Allow configurable config home directory #42

merged 4 commits into from
Oct 17, 2023

Conversation

mnorbury
Copy link
Contributor

No description provided.

@mnorbury mnorbury requested a review from hermanschaaf October 17, 2023 14:46
hermanschaaf
hermanschaaf reviewed Oct 17, 2023
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
hermanschaaf
hermanschaaf approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we might also need some similar functions for setting the XDG Data directory.

@mnorbury @hermanschaaf
Update config/config.go
db1642d 
Co-authored-by: Herman Schaaf <[email protected]>
@mnorbury mnorbury force-pushed the feat/allow-configurable-config-home branch from 78f93c0 to db1642d Compare October 17, 2023 14:49
@mnorbury
Copy link
Contributor Author

Looks good, though we might also need some similar functions for setting the XDG Data directory.

Good point. Hopefully not over the top, but d532a83 now confines xdg dependency to the config package and allows both config and data directories to be configured.

@mnorbury mnorbury added the automerge Add to automerge PRs once requirements are met label Oct 17, 2023
@kodiakhq kodiakhq bot merged commit 3235143 into main Oct 17, 2023
5 checks passed
@kodiakhq kodiakhq bot deleted the feat/allow-configurable-config-home branch October 17, 2023 15:37
@cq-bot cq-bot mentioned this pull request Oct 17, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Oct 17, 2023
@cq-bot
chore(main): Release v1.4.0 (#43)
aec92fa 
🤖 I have created a release *beep* *boop*
---


## [1.4.0](v1.3.0...v1.4.0) (2023-10-17)


### Features

* Allow configurable config home directory ([#42](#42)) ([3235143](3235143))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

Assignees
No one assigned
Labels
automerge Add to automerge PRs once requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnorbury @hermanschaaf